1102317 - Keypads should always be displayed in LTR, even in RTL mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

The keypad is shifted too far to the right and seems out of place in RTL. We should center it so that it is laid out the same way as in LTR. See attached screenshot.

Comment 1

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 2

[Paco Rampas [:paco]]

Attachment: keypad-rtl-ltr.png

Comment 3

[Paco Rampas [:paco]]

Comment on attachment 8528235 [details] [review]
patch in github

Hi Doug,

Now, we are forcing the ltr keyboard in both scenarios (html dir: rtl and dir: ltr). Only one thing more, notice you that the buttons of bottom (add user button and call button) are changing with the direction change. So, I added a -moz-margin-start and now, the the code is working fine in both scenarios.

Thanks

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8528235 [details] [review]
patch in github

Thanks Paco, this generally looks good. I left a few comments on the PR. Please address them before landing.

I'm also going to dupe bug 1011731 to this bug since it's fixed by this patch.

When you get a chance, please also make a demo and post it on the sprint demo page:
https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/v2.2-S1#Demos

Comment 6

[Paco Rampas [:paco]]

Attachment: keypad-rtl-1099397.png

Comment 7

[Paco Rampas [:paco]]

Hi Doug ,

I have uploaded the demo scheenshot into wiki as a link because i can't upload files. German Said me that he has a section "upload file" into the tools category, but I haven't this option. Could be a problem with my account privileges ?

Thanks

Comment 8

[Doug Sherk (:drs) (inactive)]

(In reply to Paco Rampas [:paco] from comment #7)
> I have uploaded the demo scheenshot into wiki as a link because i can't
> upload files. German Said me that he has a section "upload file" into the
> tools category, but I haven't this option. Could be a problem with my
> account privileges ?

Yes, you have to have 10 edits before you're granted file upload permissions. See https://wiki.mozilla.org/MozillaWiki:News/2014-10/Changes_to_user_group_rights#What_rights_will_each_user_group_have_under_this_new_configuration.3F

To get to 10 edits, you can just edit your personal user page 10 times.

If you have more problems after that, see https://wiki.mozilla.org/MozillaWiki:News/2014-10/Changes_to_user_group_rights#Notice_any_issues.3F or let me know.

Comment 9

[Paco Rampas [:paco]]

merged: c86b2e4c2dac7e949e47953956746f632bbdcd71

Comment 10

[Elie]

According comment 3
The design is that forcing the ltr keyboard in both scenarios (html dir: rtl and dir: ltr). Only one thing more, notice you that the buttons of bottom (add user button and call button) are changing with the direction change.
This issue verified successfully on Flame2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6
Build-ID        20150119002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Refer to picture 2015-01-19-04-10-51.png

Comment 11

[Elie]

Attachment: 2015-01-19-04-10-51.png